Broken images....

by Biggest_Mike

Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
02-12-2017, 02:21 PM
#66044 (26)
(02-11-2017, 10:19 PM)Backlash Wrote: Images seem to be spotty for me again. Anyone else been having this issue?

The thing seems to fall over every so often. I'm adding graphing of stats to try and debug.
Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
02-12-2017, 07:28 PM
#66052 (27)
(02-12-2017, 02:21 PM)RX14 Wrote:
(02-11-2017, 10:19 PM)Backlash Wrote: Images seem to be spotty for me again. Anyone else been having this issue?

The thing seems to fall over every so often. I'm adding graphing of stats to try and debug.

I'm noticing a socket leak, so i've set it to restart every 2 hours. I'll try to get a more permenant fix ASAP.
[+] 1 user loves Steph's post
malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
02-24-2017, 06:57 PM
#66653 (28)
It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

„Mad in Madrid, must be the wine, Señor~”
tn5421
Sharing: For a better tomorrow
Torrents
Posts: 1,527
Threads: 43
Joined: May 2015
Reputation: 14
02-25-2017, 12:23 AM
#66657 (29)
(02-24-2017, 06:57 PM)malmon Wrote: It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

Line 6, /src/camo/config.cr
Code:
getter length_limit : Int32 = 5 * MiB

my sc2 replays&info | my osu stuff | my steam | my kitsu
Do you like to read or write fanfiction? Then please check out my usergroup.
malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
02-25-2017, 05:29 AM
#66660 (30)
(02-25-2017, 12:23 AM)tn5421 Wrote:
(02-24-2017, 06:57 PM)malmon Wrote: It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

Line 6, /src/camo/config.cr
Code:
getter length_limit : Int32 = 5 * MiB

Hmm, what an odd thing to have in the code :')
Though couldn't the proxy just redirect to the original link instead if the size is too big?

„Mad in Madrid, must be the wine, Señor~”
Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
02-25-2017, 09:11 AM
#66663 (31)
(02-25-2017, 05:29 AM)malmon Wrote:
(02-25-2017, 12:23 AM)tn5421 Wrote:
(02-24-2017, 06:57 PM)malmon Wrote: It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

Line 6, /src/camo/config.cr
Code:
getter length_limit : Int32 = 5 * MiB

Hmm, what an odd thing to have in the code :')
Though couldn't the proxy just redirect to the original link instead if the size is too big?

I'll increase it to 10MiB. Honestly, if your image is 5MiB or larger it's way, way too large already. In the future we'll probably control image embeds much more, at least on mobile, to ensure that loading a single forum thread doesn't eat your whole mobile data allowance.
tn5421
Sharing: For a better tomorrow
Torrents
Posts: 1,527
Threads: 43
Joined: May 2015
Reputation: 14
02-27-2017, 11:31 PM
#66732 (32)
(02-25-2017, 09:11 AM)RX14 Wrote:
(02-25-2017, 05:29 AM)malmon Wrote:
(02-25-2017, 12:23 AM)tn5421 Wrote:
(02-24-2017, 06:57 PM)malmon Wrote: It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

Line 6, /src/camo/config.cr
Code:
 getter length_limit : Int32 = 5 * MiB

Hmm, what an odd thing to have in the code :')
Though couldn't the proxy just redirect to the original link instead if the size is too big?

I'll increase it to 10MiB. Honestly, if your image is 5MiB or larger it's way, way too large already. In the future we'll probably control image embeds much more, at least on mobile, to ensure that loading a single forum thread doesn't eat your whole mobile data allowance.

I added the PR like the sleazy fuck I am.

my sc2 replays&info | my osu stuff | my steam | my kitsu
Do you like to read or write fanfiction? Then please check out my usergroup.
[+] 1 user loves tn5421's post
malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
02-28-2017, 06:54 PM (This post was last modified: 02-28-2017, 08:42 PM by malmon.)
#66752 (33)
Probably a bit off topic, but is it possible to embed an image that bypasses the proxy? I want to put a dynamic image in my sig, but it'll be pointless if it gets cached.

Also, the 2nd image in my sig times out for some reason. It also doesn't show up in markdown files on GitHub.

„Mad in Madrid, must be the wine, Señor~”
Clickbait
unlucky
bulli
Posts: 4,049
Threads: 221
Joined: Jul 2014
Reputation: 66
02-28-2017, 08:57 PM
#66755 (34)
being able to bypass the proxy defeats the purpose of having the proxy

malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
02-28-2017, 09:25 PM
#66757 (35)
(02-28-2017, 08:57 PM)Clickbait Wrote: being able to bypass the proxy defeats the purpose of having the proxy

Fair enough, though I'm still not sure why my 2nd image is timing out. URL is https://maciozo.com/dontdelete/np.png

„Mad in Madrid, must be the wine, Señor~”
malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
03-03-2017, 02:58 PM
#66845 (36)
(02-25-2017, 09:11 AM)RX14 Wrote:
(02-25-2017, 05:29 AM)malmon Wrote:
(02-25-2017, 12:23 AM)tn5421 Wrote:
(02-24-2017, 06:57 PM)malmon Wrote: It seems to not like large images?

https://u.nya.is/fjthso.jpg

Returns "Content-Length limit exceeded"

https://proxy.lewd.sx/ee5d8583bf74d59986...f2e6a7067/

Line 6, /src/camo/config.cr
Code:
getter length_limit : Int32 = 5 * MiB

Hmm, what an odd thing to have in the code :')
Though couldn't the proxy just redirect to the original link instead if the size is too big?

In the future we'll probably control image embeds much more, at least on mobile, to ensure that loading a single forum thread doesn't eat your whole mobile data allowance.

How much more though? Because even the current setup renders dynamic images useless.

„Mad in Madrid, must be the wine, Señor~”
Backlash
TAIWAN NUMBAH ONE!
Nephilim
Posts: 3,076
Threads: 63
Joined: Oct 2015
Reputation: 29
03-21-2017, 09:54 AM
#67409 (37)
Can't see shit, cap'n. Y'all workin' on the image proxy again?

[+] 1 user loves Backlash's post
malmon
mjał
Neko
Posts: 3,429
Threads: 42
Joined: Nov 2015
Reputation: 21
03-21-2017, 04:45 PM
#67417 (38)
(03-21-2017, 09:54 AM)Backlash Wrote: Can't see shit, cap'n. Y'all workin' on the image proxy again?

I feel like this feature has caused more problems than it has solved

„Mad in Madrid, must be the wine, Señor~”
Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
03-22-2017, 10:30 AM (This post was last modified: 03-22-2017, 10:30 AM by Steph.)
#67450 (39)
(03-21-2017, 04:45 PM)malmon Wrote:
(03-21-2017, 09:54 AM)Backlash Wrote: Can't see shit, cap'n. Y'all workin' on the image proxy again?

I feel like this feature has caused more problems than it has solved

We'd need the feature either way, it's just that this new implementation seems to be subtly broken. I don't know why it's broken because it's essentially impossible to reproduce, but i've made sure to fix the reboot every 2h feature.
Backlash
TAIWAN NUMBAH ONE!
Nephilim
Posts: 3,076
Threads: 63
Joined: Oct 2015
Reputation: 29
01-08-2018, 10:29 PM
#75252 (40)
Am I the only one getting more broken images? I've had to shelve at least two posts just 'cuz I couldn't include the images that went with. :c

All in One
( ˃ ヮ˂)
Kohai
Posts: 1,138
Threads: 9
Joined: May 2016
Reputation: 5
01-08-2018, 11:27 PM
#75255 (41)
(01-08-2018, 10:29 PM)Backlash Wrote: Am I the only one getting more broken images? I've had to shelve at least two posts just 'cuz I couldn't include the images that went with. :c

>more


They're pretty much all ded on my end. Except for sigs.

 
Ceres
Limbo Waltzing
Music
Posts: 112
Threads: 3
Joined: Apr 2017
Reputation: 2
01-09-2018, 01:20 AM (This post was last modified: 01-09-2018, 01:22 AM by Ceres.)
#75256 (42)
Everything image related seems quite broken for the most part, going through multiple threads

This makes going through the barefoot cuties thread a lot harder now :(
[+] 1 user loves Ceres's post
Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
01-09-2018, 10:15 AM
#75259 (43)
Fixed now, my bad. I introduced a stack overflow error when there was an invalid URL so it kept crashing.

https://github.com/RX14/camo.cr/commit/9...0964b607be
[+] 2 users love Steph's post
Backlash
TAIWAN NUMBAH ONE!
Nephilim
Posts: 3,076
Threads: 63
Joined: Oct 2015
Reputation: 29
02-21-2019, 01:19 AM
#81313 (44)
Hey, so this isn't related to broken images, but this bug prevents me from making new topics, so this is the best I can do. Apparently, pomf.is must be under new ownership or something, as attempting to use the detailed reply editor redirects you to an empty page on pomf.is; same for if you'd like to start a new topic.

Naturally, this is infuriating. @Senko-san , any chance we could get a quick fix?

[+] 2 users love Backlash's post
Steph
Hehe~
Posts: 1,002
Threads: 10
Joined: Nov 2015
Reputation: 7
02-24-2019, 07:21 AM
#81343 (45)
(02-21-2019, 01:19 AM)Backlash Wrote: Hey, so this isn't related to broken images, but this bug prevents me from making new topics, so this is the best I can do. Apparently, pomf.is must be under new ownership or something, as attempting to use the detailed reply editor redirects you to an empty page on pomf.is; same for if you'd like to start a new topic.

Naturally, this is infuriating. @Senko-san , any chance we could get a quick fix?

Sorry for the delay but it's fixed now >_<
[+] 2 users love Steph's post
Backlash
TAIWAN NUMBAH ONE!
Nephilim
Posts: 3,076
Threads: 63
Joined: Oct 2015
Reputation: 29
02-24-2019, 10:31 AM
#81349 (46)
(02-24-2019, 07:21 AM)Senko-san Wrote:
(02-21-2019, 01:19 AM)Backlash Wrote: Hey, so this isn't related to broken images, but this bug prevents me from making new topics, so this is the best I can do. Apparently, pomf.is must be under new ownership or something, as attempting to use the detailed reply editor redirects you to an empty page on pomf.is; same for if you'd like to start a new topic.

Naturally, this is infuriating. @Senko-san , any chance we could get a quick fix?

Sorry for the delay but it's fixed now >_<

No worries! Thaanks qt. <3

[Image: 68747470733a2f2f617661746172732e6d64732e...2f6f726967]

[+] 1 user loves Backlash's post
Yuu
Cinephile
Cinema
Posts: 147
Threads: 3
Joined: Aug 2014
Reputation: 15
02-25-2019, 08:31 AM
#81358 (47)
(02-21-2019, 01:19 AM)Backlash Wrote: Hey, so this isn't related to broken images, but this bug prevents me from making new topics, so this is the best I can do. Apparently, pomf.is must be under new ownership or something, as attempting to use the detailed reply editor redirects you to an empty page on pomf.is; same for if you'd like to start a new topic.

Naturally, this is infuriating. @Senko-san , any chance we could get a quick fix?

Spooky. Had to install noscript to block it so I could make posts.
Good to hear it's fixed.
[+] 2 users love Yuu's post